Skip to content

The nature of the "base" context of tests matters and must be included in parametric tests #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OlivierBBB opened this issue Feb 5, 2025 · 0 comments
Labels
documentation Improvements or additions to documentation testing unit tests

Comments

@OlivierBBB
Copy link
Collaborator

The last bug that remained in the EVM test suite highlights the importance of writing tests two ways: where the "base" (e.g. root of call frame tree) context is either

  • CONTRACT_CREATION
  • MESSAGE_CALL

Specifically the issue was when exploring the scenario/CALL_EOA_SUCCESS_WILL_REVERT where the caller was undergoing deployment and the deployment reverted. The issue was that when "undoing" the CALL at REVERT time we were using a more updated snapshot of the caller account, specifically one where the deployment had already been reverted. This clashed with account_consistency constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing unit tests
Projects
None yet
Development

No branches or pull requests

1 participant