Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use client customization for keyvault-keys cryptography models #32636

Open
maorleger opened this issue Jan 21, 2025 · 0 comments
Open

Use client customization for keyvault-keys cryptography models #32636

maorleger opened this issue Jan 21, 2025 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@maorleger
Copy link
Member

maorleger commented Jan 21, 2025

As a first pass we copied various enums from the generated code to the hand-authored version in order to resolve some compatibility issues in naming and avoid breaking changes.

A better approach would be to use client.tsp customization to rename the keys as needed. This issue tracks:

  1. Updating the client.tsp

  2. Regenerating code

  3. Removing the hand-authored version

           Yes, this is an accepted breaking [discussed here](https://github.com/Azure/autorest.typescript/issues/2832#issuecomment-2499507467) and we keep some special chars e.g underscore here between numbers or before/ending with numbers.
    

If you think the name here is not reasonable, you could use client name to rename.

@@clientName(JsonWebKeyCurveName.P256_K, "P256K", "javascript");

Also we are open to hear feedbacks for this breaking if you have any concern feel free to raise your concern in codegen issue.

Originally posted by @MaryGao in #31845 (comment)

@maorleger maorleger self-assigned this Jan 21, 2025
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 21, 2025
@maorleger maorleger added Client This issue points to a problem in the data-plane of the library. KeyVault labels Jan 21, 2025
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
Status: Untriaged
Development

No branches or pull requests

1 participant