Fix inverted coverage ranges and clamp column numbers to >=1 (#363)

* Avoid setting {start,end}_column to undefined in annotations * Deal with inverted location ranges in coverage annotations * Update test snapshots * Fixed eslint issues --------- Co-authored-by: Artiom Tretjakovas <[email protected]>
ArtiomTr · Apr 23, 2023 · aaee641 · aaee641
1 parent 952a059
commit aaee641
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 643 deletions.
diff --git a/src/annotations/createCoverageAnnotations.ts b/src/annotations/createCoverageAnnotations.ts
@@ -14,16 +14,14 @@ const getLocation = (
     start_column?: number;
     end_column?: number;
 } => ({
-    start_line: start.line,
-    end_line: end.line,
-    start_column:
-        start.line === end.line && start.column !== null && end.column !== null
-            ? start.column
-            : undefined,
-    end_column:
-        start.line === end.line && start.column !== null && end.column !== null
-            ? end.column
-            : undefined,
+    start_line: Math.min(start.line, end.line),
+    end_line: Math.max(end.line),
+    ...(start.line === end.line && start.column != null && end.column != null
+        ? {
+              start_column: Math.max(1, Math.min(start.column, end.column)),
+              end_column: Math.max(1, start.column, end.column),
+          }
+        : {}),
 });
 
 export const createCoverageAnnotations = (